fix(core): handle empty translations correctly #36499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
state: WIP
area: i18n
area: core
AndrewKushnir
force-pushed
the
i18n_empty_translations
branch
from
9e77f5d
to
2576f36
Compare
AndrewKushnir
added
action: review
|
As described in this issue comment, this PR (slightly adapted to apply on Angular 9.0.7) solves the problem for me 👍 |
petebacondarwin
approved these changes
Apr 9, 2020
AndrewKushnir
added
action: presubmit
In certain use-cases it's useful to have an ability to use empty strings as translations. Currently Ivy fails at runtime if empty string is used as a translation, since some parts of internal data structures are not created properly. This commit updates runtime i18n logic to handle empty translations and avoid unnecessary extra processing for such cases. Fixes angular#36476.
AndrewKushnir
force-pushed
the
i18n_empty_translations
branch
from
aaabfa0
to
512f5a8
Compare
mhevery
approved these changes
Apr 15, 2020
AndrewKushnir
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Apr 16, 2020
In certain use-cases it's useful to have an ability to use empty strings as translations. Currently Ivy fails at runtime if empty string is used as a translation, since some parts of internal data structures are not created properly. This commit updates runtime i18n logic to handle empty translations and avoid unnecessary extra processing for such cases. Fixes #36476. PR Close #36499
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain use-cases it's useful to have an ability to use empty strings as translations. Currently Ivy fails at runtime if empty string is used as a translation, since some parts of internal data structures are not created properly. This commit updates runtime i18n logic to handle empty translations and avoid unnecessary extra processing for such cases.
Fixes #36476.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?